lkml.org 
[lkml]   [2017]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: via82xx: Use common error handling code in snd_via82xx_create()
On Tue, Aug 22, 2017 at 10:05:37PM +0200, SF Markus Elfring wrote:
> >> @@ -1121,30 +1121,27 @@ static int snd_via82xx_create(struct snd_card *card,
> >>
> >> if ((err = pci_request_regions(pci, card->driver)) < 0) {
> >> kfree(chip);
> >> - pci_disable_device(pci);
> >> - return err;
> >> + goto disable_device;

Ah, you're right. It's not leaking. I thought you deleted the
kfree(chip);...

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-08-22 22:19    [W:0.044 / U:46.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site