lkml.org 
[lkml]   [2017]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH][next] efi/reboot: make function pointer orig_pm_power_off static
On 22 August 2017 at 16:50, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function pointer orig_pm_power_off is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'orig_pm_power_off' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Queued, thanks.

> ---
> drivers/firmware/efi/reboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/reboot.c b/drivers/firmware/efi/reboot.c
> index 7117e2d0c7f9..22874544d301 100644
> --- a/drivers/firmware/efi/reboot.c
> +++ b/drivers/firmware/efi/reboot.c
> @@ -5,7 +5,7 @@
> #include <linux/efi.h>
> #include <linux/reboot.h>
>
> -void (*orig_pm_power_off)(void);
> +static void (*orig_pm_power_off)(void);
>
> int efi_reboot_quirk_mode = -1;
>
> --
> 2.14.1
>

\
 
 \ /
  Last update: 2017-08-22 18:33    [W:0.044 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site