lkml.org 
[lkml]   [2017]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2 v7] printk: Add monotonic, boottime, and realtime timestamps
From
Date


On 08/22/2017 10:23 AM, Petr Mladek wrote:
> On Tue 2017-08-22 10:09:40, Prarit Bhargava wrote:
>>
>>
>> On 08/17/2017 11:30 AM, Mark Salyzyn wrote:
>>> On 08/17/2017 06:15 AM, Prarit Bhargava wrote:
>>>> printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock
>>>> timestamp to printk messages. The local hardware clock loses time each
>>>> day making it difficult to determine exactly when an issue has occurred in
>>>> the kernel log, and making it difficult to determine how kernel and
>>>> hardware issues relate to each other in real time.
>>> Congrats, greatly eases merges into older kernels, and has eliminated the churn
>>> this could place on all the configured systems out there.
>>>
>>> Sadly, one of my suggestions did not quite go the way I expected ;-} easy to
>>> correct, and fix (I missed a spot in my original suggestion, as code changed
>>> underfoot over the set ;-/). (see bottom)
>>
>> Added. I will send out v8 shortly.
>
> It might make sense to wait a bit. I am in the middle of v7 review and
> have several comments.
>
> I would suggest to slow down this a bit anyway. You sent 7 versions
> within three weeks. It improved nicely over time. But I think that
> I am not the only one who has troubles to follow.
>

np Petr. I will hold off on v8.

P.

> Best Regards,
> Petr
>

\
 
 \ /
  Last update: 2017-08-22 16:45    [W:0.056 / U:5.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site