Messages in this thread | | | Date | Tue, 22 Aug 2017 16:44:16 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v2 01/19] perf, tools: Save max_x, max_y in xyarray |
| |
On Tue, Aug 22, 2017 at 11:40:50AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Aug 22, 2017 at 10:20:28AM +0200, Jiri Olsa escreveu: > > On Fri, Aug 11, 2017 at 04:26:16PM -0700, Andi Kleen wrote: > > > From: Andi Kleen <ak@linux.intel.com> > > > +static inline int xy_max_y(struct xyarray *xy) > > > +{ > > > + return xy->max_x; > > > +} > > > + > > > +static inline int xy_max_x(struct xyarray *xy) > > > +{ > > > + return xy->max_y; > > > +} > > > > I think you should follow the standard naming > > and use xyarray__max_x and xyarray__max_y > > Yeah, will take just a bit longer to process, I'll fix that up...
fyi it's used in following patch
jirka
| |