lkml.org 
[lkml]   [2017]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
On Tue, 22 Aug 2017 14:16:25 +0200,
Dan Carpenter wrote:
>
> err = snd_card_register(card);
> > - if (err < 0) {
> > + if (err) {
> > +free_card:
> > snd_card_free(card);
> > return err;
> > }
>
> I thought we agreed, yesterday, to never use this style of error
> handling?

Yeah, this is definitely no-go.

Also, please don't omit the negative value check.


thanks,

Takashi

\
 
 \ /
  Last update: 2017-08-22 14:28    [W:0.061 / U:6.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site