lkml.org 
[lkml]   [2017]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] ACPI / PMIC: Add opregion driver for Intel Dollar Cove TI PMIC
On Tue, 22 Aug 2017 11:58:35 +0200,
Andy Shevchenko wrote:
>
> On Tue, 2017-08-22 at 07:57 +0200, Takashi Iwai wrote:
> > This patch adds the opregion driver for Dollar Cove TI PMIC on Intel
> > Cherry Trail devices.  The patch is based on the original work by
> > Intel, found at:
> >       https://github.com/01org/ProductionKernelQuilts
> > with many cleanups and rewrites.
> >
> > The driver is currently provided only as built-in to follow other
> > PMIC opregion drivers convention.
> >
> > The re-enumeration of devices at probe is required for fixing the
> > issues on HP x2 210 G2.  See bug#195689.
> >
> >
>
> > +static int dc_ti_pmic_get_raw_temp(struct regmap *regmap, int reg)
> > +{
> > + int temp_l, temp_h;
> > +
> > + if (regmap_read(regmap, reg, &temp_l) ||
> > +     regmap_read(regmap, reg - 1, &temp_h))
> > + return -EIO;
> > +
> > + return temp_l | (temp_h & 0x3) << 8;
> > +}
>
> I'm not sure I understand this "- 1" part along with choice of l and h
> suffixes.
>
> Does it mean the register is big endian?

Good point, I need to check the original code and the values.
This can be a typo of '+', of course.


thanks,

Takashi

\
 
 \ /
  Last update: 2017-08-22 12:26    [W:0.052 / U:11.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site