Messages in this thread | | | Subject | Re: [RFC v1 1/6] platform/x86: intel_pmc_ipc: Fix error handling in ipc_pci_probe() | From | sathya <> | Date | Mon, 21 Aug 2017 22:01:06 -0700 |
| |
Hi Andy,
On 08/18/2017 05:22 AM, Andy Shevchenko wrote: > On Tue, Aug 1, 2017 at 9:13 PM, > <sathyanarayanan.kuppuswamy@linux.intel.com> wrote: >> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >> >> This patch adds proper error handling for failure cases in >> ipc_pci_probe() function. >> >> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> >> --- >> drivers/platform/x86/intel_pmc_ipc.c | 23 ++++++++++++++++++----- >> 1 file changed, 18 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c >> index bb792a5..7b65237 100644 >> --- a/drivers/platform/x86/intel_pmc_ipc.c >> +++ b/drivers/platform/x86/intel_pmc_ipc.c >> @@ -489,33 +489,46 @@ static int ipc_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) >> >> ret = pci_enable_device(pdev); >> if (ret) >> - return ret; >> + goto release_device; > Instead of doing this way and ping-ponging code in the same series, > better to switch to managed PCI functions in the first place. ok. I will merge this patch and "Use devm_* calls in driver probe" patch into a single patch.
>
- Sathya
| |