lkml.org 
[lkml]   [2017]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns
From
Date
On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tudor@nxp.com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> >
> > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > this place, so fix it.
>
> You will just get someone else fixing it as it is not what checkpatch
> recommends, so just leave it as-is please.

No. That's not correct.

checkpatch does not make a recommendation about
style use with the strcmp family of functions.

\
 
 \ /
  Last update: 2017-08-23 04:35    [W:0.051 / U:4.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site