[lkml]   [2017]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 00/14] mpt3sas driver NVMe support:


> mpt3sas: SGL to PRP Translation for I/Os to NVMe devices

I'm still confused about this patch.

- I don't understand why you go through all these hoops to decide
whether to use PRPs or IEEE scatterlists. If the firmware translation
is slow, why even bother with the SG format in the first place? Set
the max I/O size to match MDTS and you're done.

- What's the benefit of using SG for regular I/O commands?

- If the unmap translation in firmware is slow, why don't you translate
WRITE SAME/w UNMAP set to DSM DEALLOCATE without requiring
applications to do encapsulated passthrough?

Also make sure you attribute your patches correctly (From: root
<>). And you don't need that
long CC: list. Just send the patch series to


Martin K. Petersen Oracle Linux Engineering

 \ /
  Last update: 2017-08-23 04:19    [W:0.116 / U:20.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site