lkml.org 
[lkml]   [2017]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/build: Use cc-option to validate stack alignment parameter

* Matthias Kaehlcke <mka@chromium.org> wrote:

> With 8f91869766c0 ("x86/build: Fix stack alignment for CLang") cc-option
> is only used to determine the name of the stack alignment option supported
> by the compiler, but not to verify that the actual parameter <option>=N is
> valid in combination with the other CFLAGS. This causes problems with older
> gcc versions which only support stack alignment on a boundary of 16 bytes
> or higher.
>
> Also use (__)cc_option to add the stack alignment option to CFLAGS to
> make sure only valid options are added.
>
> Fixes: 8f91869766c0 ("x86/build: Fix stack alignment for CLang")
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>

I've added the kbuild-bot Reported-by tag to document (and credit) how this bug
was found.

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-08-21 09:54    [W:0.056 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site