Messages in this thread | | | From | Timofey Titovets <> | Date | Mon, 21 Aug 2017 13:50:27 +0300 | Subject | Re: [PATCH 4/4] btrfs: Delete an unnecessary variable initialisation in tree_mod_log_eb_copy() |
| |
Don't needed, and you did miss several similar places (L573 & L895) in that file with explicit initialisation.
Reviewed-by: Timofey Titovets <nefelim4ag@gmail.com>
2017-08-20 23:20 GMT+03:00 SF Markus Elfring <elfring@users.sourceforge.net>: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 20 Aug 2017 22:02:54 +0200 > > The variable "tm_list" will eventually be set to an appropriate pointer > a bit later. Thus omit the explicit initialisation at the beginning. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > fs/btrfs/ctree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c > index 3b49f39eaaf6..78387f5be0ce 100644 > --- a/fs/btrfs/ctree.c > +++ b/fs/btrfs/ctree.c > @@ -801,7 +801,7 @@ tree_mod_log_eb_copy(struct btrfs_fs_info *fs_info, struct extent_buffer *dst, > unsigned long src_offset, int nr_items) > { > int ret = 0; > - struct tree_mod_elem **tm_list = NULL; > + struct tree_mod_elem **tm_list; > struct tree_mod_elem **tm_list_add, **tm_list_rem; > int i; > int locked = 0; > -- > 2.14.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Have a nice day, Timofey.
| |