lkml.org 
[lkml]   [2017]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] net: phy: Don't use drv when it is NULL in phy_attached_print
From
Date
Hello!

On 8/21/2017 10:52 AM, Romain Perier wrote:

> Currently, if this logging function is used prior the phy driver is
> binded to the phy device (that is usually done from .ndo_open),

s/binded/bound/.

> 'phydev->drv' might be NULL, resulting in a kernel crash. That is
> typically the case in the stmmac driver, info about the phy is displayed
> during the registration of the MDIO bus, and then genphy driver is binded

Likewise.

> to this phydev when .ndo_open is called.
>
> This commit fixes the issue by using the right genphy driver, when
> phydev->drv is NULL.
>
> Fixes: commit fbca164776e4 ("net: stmmac: Use the right logging functi")

"Commit" not needed here.

> Signed-off-by: Romain Perier <romain.perier@collabora.com>
[...]

MBR, Sergei

\
 
 \ /
  Last update: 2017-08-21 11:46    [W:0.066 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site