[lkml]   [2017]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[tip:efi/core] efi/arm/arm64: Add missing assignment of efi.config_table
Commit-ID:  9a9de5c044be14c3337ef45174ac8baa568a0f93
Author: Ard Biesheuvel <>
AuthorDate: Fri, 18 Aug 2017 20:49:38 +0100
Committer: Ingo Molnar <>
CommitDate: Mon, 21 Aug 2017 09:43:49 +0200

efi/arm/arm64: Add missing assignment of efi.config_table

The ARM EFI init code never assigns the config_table member of the
efi struct, which means the sysfs device node is missing, and other
in-kernel users will not work correctly. So add the missing assignment.

Note that, for now, the runtime and fw_vendor members are still
omitted. This is deliberate: exposing physical addresses via sysfs nodes
encourages behavior that we would like to avoid on ARM (given how it is
more finicky about using correct memory attributes when mapping memory
in userland that may be mapped by the kernel already as well).

Signed-off-by: Ard Biesheuvel <>
Cc: Linus Torvalds <>
Cc: Matt Fleming <>
Cc: Peter Zijlstra <>
Cc: Thomas Gleixner <>
Signed-off-by: Ingo Molnar <>
drivers/firmware/efi/arm-init.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
index 0aa4ce7..80d1a88 100644
--- a/drivers/firmware/efi/arm-init.c
+++ b/drivers/firmware/efi/arm-init.c
@@ -145,6 +145,9 @@ static int __init uefi_init(void)

+ if (!retval)
+ efi.config_table = (unsigned long)efi.systab->tables;
early_memunmap(config_tables, table_size);
early_memunmap(efi.systab, sizeof(efi_system_table_t));
 \ /
  Last update: 2017-08-21 11:22    [W:0.111 / U:17.096 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site