Messages in this thread | | | Date | Sun, 20 Aug 2017 10:17:02 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 2/3] iio: light: apds9300: constify i2c_device_id |
| |
On Sun, 20 Aug 2017 00:17:37 +0530 Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> i2c_device_id are not supposed to change at runtime. All functions > working with i2c_device_id provided by <linux/i2c.h> work with > const i2c_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied.
Thanks,
Jonathan > --- > drivers/iio/light/apds9300.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/apds9300.c b/drivers/iio/light/apds9300.c > index 649b26f..05eacd1 100644 > --- a/drivers/iio/light/apds9300.c > +++ b/drivers/iio/light/apds9300.c > @@ -505,7 +505,7 @@ static SIMPLE_DEV_PM_OPS(apds9300_pm_ops, apds9300_suspend, apds9300_resume); > #define APDS9300_PM_OPS NULL > #endif > > -static struct i2c_device_id apds9300_id[] = { > +static const struct i2c_device_id apds9300_id[] = { > { APDS9300_DRV_NAME, 0 }, > { } > };
| |