lkml.org 
[lkml]   [2017]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access
From
Date

Den 01.08.2017 22.14, skrev David Lechner:
> If we return here and import_attach is true, then dma_buf_end_cpu_access()
> will not be called balance dma_buf_begin_cpu_access().
>
> Fix by setting ret instead of returning.
>
> Signed-off-by: David Lechner <david@lechnology.com>
> ---

Reviewed-by: Noralf Trønnes <noralf@tronnes.org>

> drivers/gpu/drm/tinydrm/mipi-dbi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c
> index c83eeb7..e10fa4b 100644
> --- a/drivers/gpu/drm/tinydrm/mipi-dbi.c
> +++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c
> @@ -183,7 +183,8 @@ static int mipi_dbi_buf_copy(void *dst, struct drm_framebuffer *fb,
> dev_err_once(fb->dev->dev, "Format is not supported: %s\n",
> drm_get_format_name(fb->format->format,
> &format_name));
> - return -EINVAL;
> + ret = -EINVAL;
> + break;
> }
>
> if (import_attach)

\
 
 \ /
  Last update: 2017-08-02 20:52    [W:0.074 / U:1.596 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site