lkml.org 
[lkml]   [2017]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH nf-next] netfilter: constify nf_loginfo structures
On Tue, Aug 01, 2017 at 12:48:03PM +0200, Julia Lawall wrote:
> The nf_loginfo structures are only passed as the seventh argument to
> nf_log_trace, which is declared as const or stored in a local const
> variable. Thus the nf_loginfo structures themselves can be const.
>
> Done with the help of Coccinelle.
>
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct nf_loginfo i@p = { ... };
>
> @ok1@
> identifier r.i;
> expression list[6] es;
> position p;
> @@
> nf_log_trace(es,&i@p,...)
>
> @ok2@
> identifier r.i;
> const struct nf_loginfo *e;
> position p;
> @@
> e = &i@p
>
> @bad@
> position p != {r.p,ok1.p,ok2.p};
> identifier r.i;
> struct nf_loginfo e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
> struct nf_loginfo i = { ... };
> // </smpl>

Applied, thanks Julia.

\
 
 \ /
  Last update: 2017-08-02 14:26    [W:0.032 / U:16.548 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site