Messages in this thread | | | Date | Wed, 2 Aug 2017 13:43:04 +0200 | From | Pavel Machek <> | Subject | Re: [RFC PATCH 1/5] dt-bindings: power: Add battery types |
| |
Hi!
> Signed-off-by: Marek Belisko <marek.belisko@gmail.com> > --- > include/dt-bindings/power/power.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > create mode 100644 include/dt-bindings/power/power.h > > diff --git a/include/dt-bindings/power/power.h b/include/dt-bindings/power/power.h > new file mode 100644 > index 0000000..ea36d7f > --- /dev/null > +++ b/include/dt-bindings/power/power.h > @@ -0,0 +1,11 @@ > +#ifndef _DT_BINDINGS_POWER_H > +#define _DT_BINDINGS_POWER_H > + > +#define POWER_SUPPLY_TECHNOLOGY_NiMH 1 > +#define POWER_SUPPLY_TECHNOLOGY_LION 2 > +#define POWER_SUPPLY_TECHNOLOGY_LIPO 3 > +#define POWER_SUPPLY_TECHNOLOGY_LiFe 4
Actually I'd add comments here, such as "/* LiFePO4 */, because otherwise it is a bit ambiguous.
> +#define POWER_SUPPLY_TECHNOLOGY_NiCd 5 > +#define POWER_SUPPLY_TECHNOLOGY_LiMn 6 > + > +#endif /* _DT_BINDINGS_POWER_H */
The rest of series is ok, you can add
Acked-by: Pavel Machek <pavel@ucw.cz>
, but I guess someone would want a little more verbose changelogs.
BTW what hardware are you working with? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |