lkml.org 
[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4.12 47/65] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume
From
Date
On Mon, 2017-08-14 at 18:19 -0700, Greg Kroah-Hartman wrote:
> 4.12-stable review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: Sandeep Singh <sandeep.singh@amd.com>
>
> commit e788787ef4f9c24aafefc480a8da5f92b914e5e6 upstream.
[...]
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -98,6 +98,7 @@ enum amd_chipset_gen {
>   AMD_CHIPSET_HUDSON2,
>   AMD_CHIPSET_BOLTON,
>   AMD_CHIPSET_YANGTZE,
> + AMD_CHIPSET_TAISHAN,
>   AMD_CHIPSET_UNKNOWN,
>  };
>  
> @@ -141,6 +142,11 @@ static int amd_chipset_sb_type_init(stru
>   pinfo->sb_type.gen = AMD_CHIPSET_SB700;
>   else if (rev >= 0x40 && rev <= 0x4f)
>   pinfo->sb_type.gen = AMD_CHIPSET_SB800;
> + }
> + pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
> +   0x145c, NULL);
> + if (pinfo->smbus_dev) {
> + pinfo->sb_type.gen = AMD_CHIPSET_TAISHAN;
>   } else {
>   pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
>   PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, NULL);
[...]

This causes pinfo->smbus_dev to be wrongly set to NULL on systems with
the ATI chipset that this function checks for first.

Ben.

--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-08-18 22:03    [W:0.286 / U:2.100 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site