lkml.org 
[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3] blktrace: Fix potentail deadlock between delete & sysfs ops
Date
On Fri, 2017-08-18 at 13:54 -0400, Waiman Long wrote:
> Instead, a global blktrace
> mutex will be used to serialize the read/write of the blktrace sysfs
> attributes.

Hello Waiman,

Using a mutex to serialize code is wrong. What is needed is exact
documentation of what data structures and/or member variables are
protected by bdev->bd_mutex and by blktrace_mutex.

Also, please spell "potential" correctly in the subject of this patch.

Thanks,

Bart.
\
 
 \ /
  Last update: 2017-08-18 20:08    [W:0.100 / U:15.876 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site