lkml.org 
[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] kernel: tracepoints: add support for relative references

* Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

> On 18 August 2017 at 09:36, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > On 18 August 2017 at 09:26, Ingo Molnar <mingo@kernel.org> wrote:
> >>
> >> * Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> >>
> >>> -static void for_each_tracepoint_range(struct tracepoint * const *begin,
> >>> - struct tracepoint * const *end,
> >>> +static void for_each_tracepoint_range(const void *begin, const void *end,
> >>> void (*fct)(struct tracepoint *tp, void *priv),
> >>> void *priv)
> >>> {
> >>> +#ifdef CONFIG_HAVE_ARCH_PREL32_RELOCATIONS
> >>> + const signed int *iter;
> >>> +
> >>> + if (!begin)
> >>> + return;
> >>> + for (iter = begin; iter < (signed int *)end; iter++) {
> >>> + fct((struct tracepoint *)((unsigned long)iter + *iter), priv);
> >>> + }
> >>
> >> I think checkpatch is correct here to complain about the unnecessary curly braces
> >> here.
> >>
> >
> > Fair enough. I will clean up to the extent feasible.
> >
>
> OK, in an honest attempt to at least remove as many of the checkpatch
> errors as I can, [...]

Note that I actually agreed with your list of checkpatch bogosities - the one I
commented on was the only thing that needed fixing, IMHO.

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-08-18 19:59    [W:0.060 / U:9.716 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site