lkml.org 
[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH 2/2] lockd: Adjust 61 checks for null pointers
From
Date
On Fri, 2017-08-18 at 15:53 +0000, Trond Myklebust wrote:
> On Thu, 2017-08-17 at 16:34 +0200, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Thu, 17 Aug 2017 16:00:18 +0200
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> >
> > The script “checkpatch.pl” pointed information out like the
> > following.
> >
> > Comparison to NULL could be written …
> >
> > Thus fix the affected source code places.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
> > fs/lockd/clnt4xdr.c | 12 ++++++------
> > fs/lockd/clntlock.c | 10 +++++-----
> > fs/lockd/clntproc.c | 12 ++++++------
> > fs/lockd/clntxdr.c | 12 ++++++------
> > fs/lockd/host.c | 22 +++++++++++-----------
> > fs/lockd/mon.c | 16 ++++++++--------
> > fs/lockd/svc.c | 4 ++--
> > fs/lockd/svc4proc.c | 6 +++---
> > fs/lockd/svclock.c | 14 +++++++-------
> > fs/lockd/svcproc.c | 6 +++---
> > fs/lockd/svcshare.c | 2 +-
> > fs/lockd/svcsubs.c | 3 +--
> > 12 files changed, 59 insertions(+), 60 deletions(-)
> >
> > diff --git a/fs/lockd/clnt4xdr.c b/fs/lockd/clnt4xdr.c
> > index c349fc0f9b80..ec6473d194fd 100644
> > --- a/fs/lockd/clnt4xdr.c
> > +++ b/fs/lockd/clnt4xdr.c
> > @@ -131,7 +131,7 @@ static int decode_netobj(struct xdr_stream *xdr,
> > __be32 *p;
> >
> > p = xdr_inline_decode(xdr, 4);
> > - if (unlikely(p == NULL))
> > + if (unlikely(!p))
>
> Oh STOP with the checkpatch wankfest!
>

:)

To elaborate: these kinds of patches are particularly unwelcome. In
particular, these sorts of changes make it difficult to backport later
patches to earlier kernels.

If you're doing meaningful work in these areas of code, then feel free
to change the style at the same time. If not though, it's best to leave
them alone.

Cheers,
--
Jeff Layton <jlayton@redhat.com>

\
 
 \ /
  Last update: 2017-08-18 18:04    [W:0.041 / U:6.208 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site