lkml.org 
[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev
> for example,
> file: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> netdev->priv_flags |= IFF_UNICAST_FLT;
>
> + /* MTU range: 81 - 9600 */
> + netdev->min_mtu = 81;
> + netdev->max_mtu = MAX_MTU;

In this cause, the driver is not using the default values. So it sets
them.

Anyway, try it. After your alloc_etherdev_mqs(), print the value of
min_mtu. It should already be set to MIN_ETH_MTU.

> I see. IMHO HNS3 is currently limited by maximum buffer per descriptor
> which is 64k. I am sure such frames would get dropped in the hardware
> itself and which I guess should be more preferable than dropping in
> driver since it saves you some precious cpu cycles?

If you hardware handles this, then you don't need to do anything.

Andrew

\
 
 \ /
  Last update: 2017-08-18 18:03    [W:0.068 / U:90.700 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site