lkml.org 
[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/3] firmware: dcdbas: constify attribute_group structures.
On 3 August 2017 at 14:37, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work with
> const attribute_group. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/firmware/dcdbas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
> index 2fe1a13..c16600f 100644
> --- a/drivers/firmware/dcdbas.c
> +++ b/drivers/firmware/dcdbas.c
> @@ -534,7 +534,7 @@ static int dcdbas_reboot_notify(struct notifier_block *nb, unsigned long code,
> NULL
> };
>
> -static struct attribute_group dcdbas_attr_group = {
> +static const struct attribute_group dcdbas_attr_group = {
> .attrs = dcdbas_dev_attrs,
> .bin_attrs = dcdbas_bin_attrs,
> };

If Douglas doesn't mind, I will take this trough the EFI tree

\
 
 \ /
  Last update: 2017-08-18 16:36    [W:0.070 / U:54.952 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site