[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 3.16 015/134] [media] serial_ir: iommap is a memory address, not bool
3.16.47-rc1 review patch.  If anyone has any objections, please let me know.


From: Sean Young <>

commit 069f3b10aed966b2da6bb1161af41da0e8880724 upstream.

This has been broken for a long time, so presumably it is not used. I
have no hardware to test this on.


Fixes: 90ab5ee ("module_param: make bool parameters really bool")

Signed-off-by: Sean Young <>
Signed-off-by: Mauro Carvalho Chehab <>
[bwh: Backported to 3.16: adjust filename, context]
Signed-off-by: Ben Hutchings <>
drivers/staging/media/lirc/lirc_serial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/staging/media/lirc/lirc_serial.c
+++ b/drivers/staging/media/lirc/lirc_serial.c
@@ -105,7 +105,7 @@ struct lirc_serial {
static int type;
static int io;
static int irq;
-static bool iommap;
+static ulong iommap;
static int ioshift;
static bool softcarrier = 1;
static bool share_irq;
@@ -1205,7 +1205,7 @@ module_param(io, int, S_IRUGO);
MODULE_PARM_DESC(io, "I/O address base (0x3f8 or 0x2f8)");

/* some architectures (e.g. intel xscale) have memory mapped registers */
-module_param(iommap, bool, S_IRUGO);
+module_param(iommap, ulong, S_IRUGO);
MODULE_PARM_DESC(iommap, "physical base for memory mapped I/O"
" (0 = no memory mapped io)");

 \ /
  Last update: 2017-08-18 16:06    [W:0.397 / U:7.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site