lkml.org 
[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 108/134] Set unicode flag on cifs echo request to avoid Mac error
    3.16.47-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Steve French <smfrench@gmail.com>

    commit 26c9cb668c7fbf9830516b75d8bee70b699ed449 upstream.

    Mac requires the unicode flag to be set for cifs, even for the smb
    echo request (which doesn't have strings).

    Without this Mac rejects the periodic echo requests (when mounting
    with cifs) that we use to check if server is down

    Signed-off-by: Steve French <smfrench@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/cifs/cifssmb.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/fs/cifs/cifssmb.c
    +++ b/fs/cifs/cifssmb.c
    @@ -720,6 +720,9 @@ CIFSSMBEcho(struct TCP_Server_Info *serv
    if (rc)
    return rc;

    + if (server->capabilities & CAP_UNICODE)
    + smb->hdr.Flags2 |= SMBFLG2_UNICODE;
    +
    /* set up echo request */
    smb->hdr.Tid = 0xffff;
    smb->hdr.WordCount = 1;
    \
     
     \ /
      Last update: 2017-08-18 15:27    [W:4.027 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site