[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 1/6] MIPS: math-emu: CMP.Sxxx.<D|S>: Prevent occurences of SIGILL crashes
From: Aleksandar Markovic <>

Fix CMP.Sxxx.<D|S> SIGILL crashes by fixing main switch/case statement
in fpu_emul() function so that inadvertent fall-troughs are prevented.

Consider, let's say, CMP.SAF.S instruction when one of inputs is zero
and another input is a signalling NaN. The desired output is zero, and
the exception flag "invalid operation" set. For such case, the main
portion of the implementation is within "d_fmt" case of the main
"switch/case" statement in fpu_emul() function. The execution will
follow one of "if-else" branches that doesn't contain "goto cop1scr;"
statement, and will therefore reach the end of "d_fmt" case. It will
subsequently fall through to the next case, "l_fmt". After follwoing
similar pattern, the execution will fall through the next case,
"default". The "default" branch contains "return SIGILL;" statement
only. This means that the caller application wil crash with "illegal
instruction" message.

It is obvious that above described fall-throughs are unnecessary and
harmfull. This patch rectifies that behavior by providing "break;"
statements at the end of cases "d_fmt_ and "l_fmt".

There are 22 instructions affected by this problem:


Signed-off-by: Miodrag Dinic <>
Signed-off-by: Goran Ferenc <>
Signed-off-by: Aleksandar Markovic <>
arch/mips/math-emu/cp1emu.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c
index f08a7b4..520a5ac 100644
--- a/arch/mips/math-emu/cp1emu.c
+++ b/arch/mips/math-emu/cp1emu.c
@@ -2394,6 +2394,7 @@ static int fpu_emu(struct pt_regs *xcp, struct mips_fpu_struct *ctx,
+ break;

case l_fmt:
@@ -2468,6 +2469,8 @@ static int fpu_emu(struct pt_regs *xcp, struct mips_fpu_struct *ctx,
+ break;
return SIGILL;
 \ /
  Last update: 2017-08-18 15:20    [W:0.033 / U:0.064 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site