lkml.org 
[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC v1 2/6] platform/x86: intel_pmc_ipc: Use devm_* calls in driver probe
On Tue, Aug 1, 2017 at 9:13 PM,
<sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> This patch cleans up unnecessary free/alloc calls in this driver
> by using devm_* calls.

> static int ipc_plat_remove(struct platform_device *pdev)
> {
> - struct resource *res;
> -
> sysfs_remove_group(&pdev->dev.kobj, &intel_ipc_group);

> - free_irq(ipcdev.irq, &ipcdev);

Can we get an IRQ at any time here?

> platform_device_unregister(ipcdev.tco_dev);
> platform_device_unregister(ipcdev.punit_dev);
> platform_device_unregister(ipcdev.telemetry_dev);

> ipcdev.dev = NULL;
> return 0;
> }


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-08-18 14:25    [W:0.065 / U:4.472 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site