lkml.org 
[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] kernel: tracepoints: add support for relative references

* Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:

> -static void for_each_tracepoint_range(struct tracepoint * const *begin,
> - struct tracepoint * const *end,
> +static void for_each_tracepoint_range(const void *begin, const void *end,
> void (*fct)(struct tracepoint *tp, void *priv),
> void *priv)
> {
> +#ifdef CONFIG_HAVE_ARCH_PREL32_RELOCATIONS
> + const signed int *iter;
> +
> + if (!begin)
> + return;
> + for (iter = begin; iter < (signed int *)end; iter++) {
> + fct((struct tracepoint *)((unsigned long)iter + *iter), priv);
> + }

I think checkpatch is correct here to complain about the unnecessary curly braces
here.

Plus why the heavy use of 'signed int' here and elsewhere in the patches - why
not 'int' ?

Plus #2, the heavy use of type casts looks pretty ugly to begin with - is there no
way to turn this into more natural code?

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-08-18 10:27    [W:0.116 / U:2.200 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site