lkml.org 
[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] arm64: dts: ls1088a: Add USB support
On Fri, Aug 18, 2017 at 07:48:19AM +0000, Yinbo Zhu wrote:
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index 3a3be87..0dbff29 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -458,6 +458,24 @@
> > status = "disabled";
> > };
> >
> > + usb0: usb3@3100000 {
> > + compatible = "snps,dwc3";
> > + reg = <0x0 0x3100000 0x0 0x10000>;
> > + interrupts = <0 80 0x4>; /* Level high type */
>
> Use IRQ_TYPE_LEVEL_HIGH, so that you can save the comment.
>
> > + dr_mode = "host";
> > + configure-gfladj;
>
> What is this? I do not see it in upstream kernel.
>
> > + snps,dis_rxdet_inp3_quirk;
>
> You probably need a "disabled" status.
>
> Shawn
>
> Hi Shawn,
>
> About your description " You probably need a "disabled" status."
> Your meaning is that remove the property "snps,dis_rxdet_inp3_quirk;", isn't it?
> In fact, if remove the property , 1088ardb usb will doesn't detect.

No, that's not what I meant. I meant the USB device should be disabled
by default in <soc>.dtsi by having the following line.

status = "disabled";

And then if your board has the pin-out of this USB device, you have the
line below to turn on the support.

status = "okay";

Shawn
\
 
 \ /
  Last update: 2017-08-18 10:06    [W:0.040 / U:5.004 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site