lkml.org 
[lkml]   [2017]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] EDAC, altera: Fix an error handling path in 'altr_edac_device_probe()'
From
Date

On 08/16/2017 12:05 AM, Christophe JAILLET wrote:
> 'res' is known to be 0 at this point.
> If 'devm_ioremap()' fails, returns -ENOMEM instead of 0 which means
> success.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/edac/altera_edac.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index fa2e5db56d24..346c4987b284 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -747,8 +747,10 @@ static int altr_edac_device_probe(struct platform_device *pdev)
> drvdata->edac_dev_name = ecc_name;
>
> drvdata->base = devm_ioremap(&pdev->dev, r->start, resource_size(r));
> - if (!drvdata->base)
> + if (!drvdata->base) {
> + res = -ENOMEM;
> goto fail1;
> + }
>
> /* Get driver specific data for this EDAC device */
> drvdata->data = of_match_node(altr_edac_device_of_match, np)->data;
>
Thank you for this patch!

Acked-by: Thor Thayer <thor.thayer@linux.intel.com>

\
 
 \ /
  Last update: 2017-08-17 17:27    [W:0.060 / U:1.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site