lkml.org 
[lkml]   [2017]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/5] KVM: x86: Add return value to kvm_cpuid().
From
Date
On 17/08/2017 14:33, Yu Zhang wrote:
>>>>
>>>> +enum {
>>>> + NO_CHECK_LIMIT = 0,
>>>> + CHECK_LIMIT = 1,
>>>> +};
>>> emulate.c should not include cpuid.h. The argument can be simply a
>>> bool, though.
>>
>> Thanks, Paolo.
>> So we just use true/false in emulate.c & svm.c, is this OK?

I would use true/false everywhere.

>> BTW could you please
> Sorry for the unfinished line. I was wondering, why can't emulate.c
> include cpuid.h?

The emulator should be separate from the rest of KVM, in principle it
could be used by userspace too. So its interface should be as limited
as possible.

Paolo

\
 
 \ /
  Last update: 2017-08-17 15:19    [W:0.064 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site