Messages in this thread | | | Subject | Re: [PATCH v2 1/5] KVM: x86: Add return value to kvm_cpuid(). | From | Yu Zhang <> | Date | Thu, 17 Aug 2017 20:33:32 +0800 |
| |
On 8/17/2017 8:23 PM, Yu Zhang wrote: > > > On 8/17/2017 8:29 PM, Paolo Bonzini wrote: >> On 17/08/2017 21:52, Yu Zhang wrote: >>> diff --git a/arch/x86/kvm/cpuid.h b/arch/x86/kvm/cpuid.h >>> index ac15193..3e759cf 100644 >>> --- a/arch/x86/kvm/cpuid.h >>> +++ b/arch/x86/kvm/cpuid.h >>> @@ -21,7 +21,14 @@ int kvm_vcpu_ioctl_set_cpuid2(struct kvm_vcpu *vcpu, >>> int kvm_vcpu_ioctl_get_cpuid2(struct kvm_vcpu *vcpu, >>> struct kvm_cpuid2 *cpuid, >>> struct kvm_cpuid_entry2 __user *entries); >>> -void kvm_cpuid(struct kvm_vcpu *vcpu, u32 *eax, u32 *ebx, u32 *ecx, >>> u32 *edx); >>> + >>> +enum { >>> + NO_CHECK_LIMIT = 0, >>> + CHECK_LIMIT = 1, >>> +}; >> emulate.c should not include cpuid.h. The argument can be simply a >> bool, though. > > Thanks, Paolo. > So we just use true/false in emulate.c & svm.c, is this OK? > BTW could you please Sorry for the unfinished line. I was wondering, why can't emulate.c include cpuid.h?
Yu
| |