lkml.org 
[lkml]   [2017]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] i40e/i40evf: use cpumask_copy() for assigning cpumask
    Date
    Using direct assignment for a cpumask is wrong, cpumask_copy() should
    be used instead.

    Otherwise crashes like the following might happen:

    [62792.326374] BUG: unable to handle kernel paging request at ffff8800049ff000
    [62792.340118] IP: [<ffffffffa2043341>] i40e_irq_affinity_notify+0x11/0x20 [i40e]
    ...
    [62792.810770] Call Trace:
    [62792.815722] [<ffffffff810d77a5>] irq_affinity_notify+0xb5/0xf0
    [62792.827593] [<ffffffff8109593e>] process_one_work+0x14e/0x410
    [62792.839282] [<ffffffff81096196>] worker_thread+0x116/0x490
    [62792.850459] [<ffffffff8109b667>] kthread+0xc7/0xe0
    [62792.860255] [<ffffffff816094bf>] ret_from_fork+0x3f/0x70
    [62792.871996] DWARF2 unwinder stuck at ret_from_fork+0x3f/0x70

    Fixes: 96db776a3682 ("i40e/i40evf: fix interrupt affinity bug")
    Cc: <stable@vger.kernel.org> # 4.10+
    Signed-off-by: Juergen Gross <jgross@suse.com>
    ---
    V2: enhance commit message, merge patches
    ---
    drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
    drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
    index 2db93d3f6d23..c0e42d162c7c 100644
    --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
    +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
    @@ -3495,7 +3495,7 @@ static void i40e_irq_affinity_notify(struct irq_affinity_notify *notify,
    struct i40e_q_vector *q_vector =
    container_of(notify, struct i40e_q_vector, affinity_notify);

    - q_vector->affinity_mask = *mask;
    + cpumask_copy(&q_vector->affinity_mask, mask);
    }

    /**
    diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
    index 7c213a347909..a4b60367ecce 100644
    --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
    +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
    @@ -520,7 +520,7 @@ static void i40evf_irq_affinity_notify(struct irq_affinity_notify *notify,
    struct i40e_q_vector *q_vector =
    container_of(notify, struct i40e_q_vector, affinity_notify);

    - q_vector->affinity_mask = *mask;
    + cpumask_copy(&q_vector->affinity_mask, mask);
    }

    /**
    --
    2.12.3
    \
     
     \ /
      Last update: 2017-08-16 19:53    [W:2.594 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site