lkml.org 
[lkml]   [2017]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] platform/chrome: cros_ec_dev - Use devm_mfd_add_devices
Hi Jeffy,

On Mon, Aug 07, 2017 at 07:18:54PM +0800, Jeffy Chen wrote:
> Currently we are calling mfd_add_devices to add devices without matched
> mfd_remove_devices to remove them.
>
> That would cause warning when re-binding cros_ec_dev:
>
> [ 123.536192] sysfs: cannot create duplicate filename '/bus/platform/devices/cros-
> ec-accel.0'
> [ 123.536210] ------------[ cut here ]------------
> [ 123.536223] WARNING: CPU: 3 PID: 156 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x68/0x
> 84
> [ 123.536226] Modules linked in:
> [ 123.536236] CPU: 3 PID: 156 Comm: bash Not tainted 4.13.0-rc3-next-20170731 #216
> [ 123.536238] Hardware name: Google Kevin (DT)
> [ 123.536242] task: ffffffc0f28bab80 task.stack: ffffffc0f1b30000
> [ 123.536247] PC is at sysfs_warn_dup+0x68/0x84
> [ 123.536251] LR is at sysfs_warn_dup+0x68/0x84
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>

Thanks for the fix. Applied for v4.14.

Thanks,
Benson

--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-08-15 08:47    [W:0.054 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site