lkml.org 
[lkml]   [2017]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 3/3] x86/efi: Use efi_switch_mm() rather than manually twiddling with cr3
    On Tue, Aug 15, 2017 at 12:18 PM, Sai Praneeth Prakhya
    <sai.praneeth.prakhya@intel.com> wrote:
    > +/*
    > + * Makes the calling kernel thread switch to/from efi_mm context
    > + * Can be used from SetVirtualAddressMap() or during efi runtime calls
    > + * (Note: This routine is heavily inspired from use_mm)
    > + */
    > +void efi_switch_mm(struct mm_struct *mm)
    > +{
    > + struct task_struct *tsk = current;
    > +
    > + task_lock(tsk);
    > + efi_scratch.prev_mm = tsk->active_mm;
    > + if (efi_scratch.prev_mm != mm) {
    > + mmgrab(mm);
    > + tsk->active_mm = mm;
    > + }
    > + switch_mm(efi_scratch.prev_mm, mm, NULL);
    > + task_unlock(tsk);
    > +
    > + if (efi_scratch.prev_mm != mm)
    > + mmdrop(efi_scratch.prev_mm);

    I'm confused. You're mmdropping an mm that you are still keeping a
    pointer to. This is also a bit confusing in the case where you do
    efi_switch_mm(efi_scratch.prev_mm).

    This whole manipulation seems fairly dangerous to me for another
    reason -- you're taking a user thread (I think) and swapping out its
    mm to something that the user in question should *not* have access to.
    What if a perf interrupt happens while you're in the alternate mm?
    What if you segfault and dump core? Should we maybe just have a flag
    that says "this cpu is using a funny mm", assert that the flag is
    clear when scheduling, and teach perf, coredumps, etc not to touch
    user memory when the flag is set?

    Admittedly, the latter problem may well have existed even before these patches.

    > +}
    > +



    > #ifdef CONFIG_EFI_MIXED
    > extern efi_status_t efi64_thunk(u32, ...);
    >
    > @@ -649,16 +665,13 @@ efi_status_t efi_thunk_set_virtual_address_map(
    > efi_sync_low_kernel_mappings();
    > local_irq_save(flags);
    >
    > - efi_scratch.prev_cr3 = read_cr3();
    > - write_cr3((unsigned long)efi_scratch.efi_pgt);
    > - __flush_tlb_all();
    > + efi_switch_mm(&efi_mm);
    >
    > func = (u32)(unsigned long)phys_set_virtual_address_map;
    > status = efi64_thunk(func, memory_map_size, descriptor_size,
    > descriptor_version, virtual_map);
    >
    > - write_cr3(efi_scratch.prev_cr3);
    > - __flush_tlb_all();
    > + efi_switch_mm(efi_scratch.prev_mm);
    > local_irq_restore(flags);
    >
    > return status;

    \
     
     \ /
      Last update: 2017-08-15 23:47    [W:4.163 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site