lkml.org 
[lkml]   [2017]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH v5 0/5] vfio-pci: Add support for mmapping MSI-X table
    From
    Date
    On Mon, 2017-08-14 at 14:12 +0100, Robin Murphy wrote:
    > On the other hand, if the check is not so much to mitigate malicious
    > guests attacking the system as to prevent dumb guests breaking
    > themselves (e.g. if some or all of the MSI-X capability is actually
    > emulated), then allowing things to sometimes go wrong on the grounds of
    > an irrelevant hardware feature doesn't seem correct :/

    There is 0 value in trying to prevent the guest kernel from shooting
    itself in the foot. There are so many other ways it can do it that I
    fail the point of even attempting it here.

    In addition, this actually harms performance on some devices. There
    are cases where the MSI-X table shares a page with other registrers
    that are used during normal device operation. This is especially
    problematic on architectures such as powerpc that use 64K pages.

    Those devices thus suffer a massive performance loss, for the sake of
    something that never happens in practice (especially on pseries where
    the MSI configuration is done by paravirt calls, thus by qemu itself).

    Cheers,
    Ben.

    \
     
     \ /
      Last update: 2017-08-15 07:45    [W:3.571 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site