Messages in this thread | | | From | Paul Moore <> | Date | Mon, 14 Aug 2017 16:59:55 -0400 | Subject | Re: [PATCH 0/4] SELinux: Fine-tuning for some function implementations |
| |
On Sun, Aug 13, 2017 at 10:43 AM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 13 Aug 2017 16:25:43 +0200 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring (4): > Delete eight unnecessary variable assignments > Adjust jump targets in ebitmap_read() > Delete an unnecessary return statement in ebitmap_destroy() > Adjust five checks for null pointers
Hi Markus,
I merged many of your patches in the past because I wanted to help encourage your involvement, but you will remember I mentioned at the time that I generally dislike merging these trivial, and often style-only, patches. I believe I even pointed you in the direction of our SELinux kernel issue tracker for a list of areas where you could help contribute in a meaningful way (link below). My earlier comments still apply; if you want to continue to contribute to SELinux in the kernel, please focus your attention on more meaningful changes. I am not going to merge any of these patches.
* https://github.com/SELinuxProject/selinux-kernel/issues
-- paul moore www.paul-moore.com
| |