lkml.org 
[lkml]   [2017]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 08/13] xen/pvcalls: implement accept command
From
Date

>> +
>> + ret = bedata->rsp[req_id].ret;
>
> You can just return bedata->rsp[req_id].ret;

Or maybe not. The slot may get reused by the time you get to the end.

-boris

>
> -boris
>
>> + /* read ret, then set this rsp slot to be reused */
>> + smp_mb();
>> + WRITE_ONCE(bedata->rsp[req_id].req_id, PVCALLS_INVALID_ID);
>> + WRITE_ONCE(map->passive.inflight_req_id, PVCALLS_INVALID_ID);
>> + return ret;
>> +}

\
 
 \ /
  Last update: 2017-08-15 04:05    [W:0.077 / U:1.084 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site