| Date | Sun, 13 Aug 2017 03:27:35 -0700 | From | Christoph Hellwig <> | Subject | Re: [[PATCH v1] 00/37] Implement SMBD protocol: Series 1 |
| |
Hi Long,
a few meta-comments:
first the split into lots of tiny lists makes the series really hard to read, I'd split it into just a few:
Patch 1: add the protocol constants Patch 2-n: core cifs modifcation required to implement SMBD Patch n+1: add the actual SMBD code Patch n+2..m: write up the core CIFS code to use it.
stcond a lot of the code doesn't seem to follow the usual Linux style. It might be a good idea to run it through scripts/checkpach.pl and at least fix the errors it generates. The warnings are much more opinioned so feel free to ignore them if they sound odd for now.
|