lkml.org 
[lkml]   [2017]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH] sched/topology: Introduce NUMA identity node sched domain
From
Date


On 8/11/17 11:57, Suravee Suthikulpanit wrote:
>
>>> [...]
>>> @@ -1445,9 +1448,24 @@ void sched_init_numa(void)
>>> tl[i] = sched_domain_topology[i];
>>>
>>> /*
>>> + * Ignore the NUMA identity level if it has the same cpumask
>>> + * as previous level. This is the case for:
>>> + * - System with last-level-cache (MC) sched domain span a NUMA node.
>>> + * - System with DIE sched domain span a NUMA node.
>>> + *
>>> + * Assume all NUMA nodes are identical, so only check node 0.
>>> + */
>>> + if (!cpumask_equal(sched_domains_numa_masks[0][0], tl[i-1].mask(0)))
>>> + tl[i++] = (struct sched_domain_topology_level){
>>> + .mask = sd_numa_mask,
>>> + .numa_level = 0,
>>> + SD_INIT_NAME(NODE)
>>> + };
>>
>> So what you've forgotten to mention is that for those systems where the
>> LLC == NODE this now superfluous level gets removed by the degenerate
>> code. Have you verified that does the right thing?
>
> Let me check with that one and get back.

Actually, it is not removed by the degenerate code. That is what this logic is
for. It checks for LCC == NODE or DIE == NODE before setting up the NODE sched
level. I can update the comment. This has also been tested on system w/ LLC == NODE.

Thanks,
Suravee

\
 
 \ /
  Last update: 2017-08-11 07:59    [W:0.055 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site