Messages in this thread | | | Subject | Re: [PATCH -next] zram: fix compr_data_size stat | From | Yisheng Xie <> | Date | Fri, 11 Aug 2017 10:07:45 +0800 |
| |
On 2017/8/11 9:38, Sergey Senozhatsky wrote: > On (08/11/17 10:35), Sergey Senozhatsky wrote: >> On (08/11/17 09:10), Yisheng Xie wrote: >>> The compr_data_size is a stat for compressed size of pages stored, which >>> should add comp_len when we compresse a page. >>> >>> Meanwhile fix typos in comment: >>> * ZRAM_SAME means page consists the same element not the entirely zero page >>> * read_from_bdev_async() return 1 to avoid call page_endio() in zram_rw_page() >>> >>> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> >> >> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > > seems that some of the changes can be folded into the existing -next patches.
Yes, feel free to fold it :)
I find Minchan is removing zram_rw_page(), so maybe the return value of read_from_bdev_async and write_to_bdev can be re-writed, it seems we need to call page_endio() depend these return value anymore, after delete zram_rw_page().
Thanks Yisheng Xie
| |