lkml.org 
[lkml]   [2017]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 05/49] fs/buffer: comment on direct access to bvec table
> +	/*
> + * It is safe to truncate the last bvec in the following way
> + * even though multipage bvec is supported, but we need to
> + * fix the parameters passed to zero_user().
> + */
> + struct bio_vec *bvec = &bio->bi_io_vec[bio->bi_vcnt - 1];

A 'we need to fix XXX' comment isn't very useful. Just fix it in the
series (which I suspect you're going to do anyway).

Also a bio_last_vec helper might be nice for something like this and
documents properly converted places much better than these comments.

\
 
 \ /
  Last update: 2017-08-10 13:16    [W:0.182 / U:1.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site