Messages in this thread | | | Subject | Re: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380 | From | Sean Wang <> | Date | Fri, 11 Aug 2017 11:11:15 +0800 |
| |
On Tue, 2017-07-18 at 14:31 +0100, Mark Brown wrote: > On Tue, Jul 18, 2017 at 05:49:23PM +0800, sean.wang@mediatek.com wrote: > > > + if (!info->modeset_mask) { > > + dev_err(&rdev->dev, "regulator %s doesn't support set_mode\n", > > + info->desc.name); > > + return -EINVAL; > > + } > > This is mostly fine but the mode operations all have this code - if the > regulator doesn't have modesetting facilities it just shouldn't have > the ops so the core can handle things in a standard fashion. It'd mean > defining a separate set of operations for those regulators but that's > fine.
Hi, Mark
it is really bad for those calls with certain regulator always returning -EINVAL, that doesn't make sense.
we'll follow your suggestion and add them into the next version.
thanks for your help!
Sean
> _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
| |