lkml.org 
[lkml]   [2017]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] printk: Clean up do_syslog() error handling
On (07/29/17 20:36), Nikitas Angelinas wrote:
> The error variable in do_syslog() is preemptively set to the error code
> before the error condition is checked, and then set to 0 if the error
> condition is not encountered. This is not necessary, as it is likely
> simpler to return immediately upon encountering the error condition. A
> redundant set of the error variable to 0 is also removed.
>
> This patch has been build-tested on x86_64, but not tested for
> functionality.
>
> Signed-off-by: Nikitas Angelinas <nikitas.angelinas@gmail.com>

looks good to me,

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>



// p.s. Petr is on vacation now

-ss

\
 
 \ /
  Last update: 2017-08-01 09:39    [W:0.058 / U:16.964 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site