| Date | Tue, 1 Aug 2017 22:34:38 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 10/28] x86/intel_rdt: Simplify info and base file lists |
| |
On Tue, 25 Jul 2017, Vikas Shivappa wrote: > for_each_alloc_enabled_rdt_resource(r) { > - kn_subdir = kernfs_create_dir(kn_info, r->name, > - kn_info->mode, r); > - if (IS_ERR(kn_subdir)) { > - ret = PTR_ERR(kn_subdir); > - goto out_destroy; > - } > - kernfs_get(kn_subdir); > - ret = rdtgroup_kn_set_ugid(kn_subdir); > - if (ret) > + fflags = r->fflags | RF_CTRL_INFO; > + if (rdtgroup_mkdir_info_resdir(r, r->name, fflags)) > goto out_destroy;
This returns uninitialized ret. Compiler warnins are overrated....
Thanks,
tglx
|