lkml.org 
[lkml]   [2017]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4.4 07/83] NFC: fix broken device allocation
From
Date
On Tue, 2017-07-25 at 12:18 -0700, Greg Kroah-Hartman wrote:
> 4.4-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Johan Hovold <johan@kernel.org>
>
> commit 20777bc57c346b6994f465e0d8261a7fbf213a09 upstream.
[...]
> --- a/net/nfc/core.c
> +++ b/net/nfc/core.c
[...]
> @@ -1077,6 +1089,11 @@ struct nfc_dev *nfc_allocate_device(stru
> }
>
> return dev;
> +
> +err_free_dev:
> + kfree(dev);
> +
> + return ERR_PTR(rc);
> }
> EXPORT_SYMBOL(nfc_allocate_device);
[...]

But the callers expect a null pointer on error, not an error pointer.
This looks broken in mainline too.

Ben.

--
Ben Hutchings
Software Developer, Codethink Ltd.


\
 
 \ /
  Last update: 2017-08-01 20:17    [W:0.282 / U:0.408 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site