lkml.org 
[lkml]   [2017]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] tracing: missing error code in tracer_alloc_buffers()
    If ring_buffer_alloc() or one of the next couple function calls fail
    then we should return -ENOMEM but the current code returns success.

    Fixes: b32614c03413 ('tracing/rb: Convert to hotplug state machine')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

    diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
    index 42b9355033d4..625c00aab800 100644
    --- a/kernel/trace/trace.c
    +++ b/kernel/trace/trace.c
    @@ -8293,6 +8293,7 @@ __init static int tracer_alloc_buffers(void)
    if (ret < 0)
    goto out_free_cpumask;
    /* Used for event triggers */
    + ret = -ENOMEM;
    temp_buffer = ring_buffer_alloc(PAGE_SIZE, RB_FL_OVERWRITE);
    if (!temp_buffer)
    goto out_rm_hp_state;
    \
     
     \ /
      Last update: 2017-08-01 13:04    [W:3.760 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site