Messages in this thread Patch in this message | | | Date | Tue, 1 Aug 2017 14:02:01 +0300 | From | Dan Carpenter <> | Subject | [PATCH] tracing: missing error code in tracer_alloc_buffers() |
| |
If ring_buffer_alloc() or one of the next couple function calls fail then we should return -ENOMEM but the current code returns success.
Fixes: b32614c03413 ('tracing/rb: Convert to hotplug state machine') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 42b9355033d4..625c00aab800 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -8293,6 +8293,7 @@ __init static int tracer_alloc_buffers(void) if (ret < 0) goto out_free_cpumask; /* Used for event triggers */ + ret = -ENOMEM; temp_buffer = ring_buffer_alloc(PAGE_SIZE, RB_FL_OVERWRITE); if (!temp_buffer) goto out_rm_hp_state;
| |