lkml.org 
[lkml]   [2017]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] usb: xhci: fix call_kern.cocci warnings
GFP_KERNEL used when a lock is held.  Convert to GFP_ATOMIC to avoid
the possibility of deadlock.

Fixes: 725d53536473 ("usb: xhci: Add DbC support in xHCI driver")
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

I don't have access to any more of the context than what is shown so I
don't know if this is a real bug.

You may want to see if it is instead possible to pull the call out of the
lock.

tree: baolu/usb/xhci/dbc/beta-v2
head: 671cb76fa0644a2f72a78fe6aac58c3c3347bc38
commit: 725d53536473cb05cdcf2b81a727ded8875a2a2f [3/4] usb: xhci: Add DbC
support in xHCI driver

xhci-dbgcap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/host/xhci-dbgcap.c
+++ b/drivers/usb/host/xhci-dbgcap.c
@@ -595,7 +595,7 @@ static int __xhci_dbc_start(struct xhci_
if (ret)
return ret;

- ret = xhci_dbc_mem_init(xhci, GFP_KERNEL);
+ ret = xhci_dbc_mem_init(xhci, GFP_ATOMIC);
if (ret)
return ret;
\
 
 \ /
  Last update: 2017-08-01 10:29    [W:0.022 / U:4.336 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site