Messages in this thread | | | Date | Wed, 2 Aug 2017 09:56:54 +0900 | From | Minchan Kim <> | Subject | Re: [PATCH v2 1/4] mm: refactoring TLB gathering API |
| |
Hi Mel,
On Tue, Aug 01, 2017 at 11:30:55AM +0100, Mel Gorman wrote: > On Tue, Aug 01, 2017 at 02:56:14PM +0900, Minchan Kim wrote: > > This patch is ready for solving race problems caused by TLB batch. > > s/is ready/is a preparatory patch/ > > > For that, we will increase/decrease TLB flush pending count of > > mm_struct whenever tlb_[gather|finish]_mmu is called. > > > > Before making it simple, this patch separates architecture specific > > part and rename it to arch_tlb_[gather|finish]_mmu and generic part > > just calls it. > > > > It shouldn't change any behavior. > > > > Cc: Ingo Molnar <mingo@redhat.com> > > Cc: Russell King <linux@armlinux.org.uk> > > Cc: Tony Luck <tony.luck@intel.com> > > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: Heiko Carstens <heiko.carstens@de.ibm.com> > > Cc: Yoshinori Sato <ysato@users.sourceforge.jp> > > Cc: Jeff Dike <jdike@addtoit.com> > > Cc: linux-arch@vger.kernel.org > > Cc: Nadav Amit <nadav.amit@gmail.com> > > Cc: Mel Gorman <mgorman@techsingularity.net> > > Signed-off-by: Minchan Kim <minchan@kernel.org> > > You could alias arch_generic_tlb_finish_mmu as arch_tlb_gather_mmu > simiilar to how other arch-generic helpers are done to avoid some > #ifdeffery but otherwise
Good idea. With Andrew's suggestion, Nadav will resend whole series including his patchset. I asked to him to fix it when he respin.
> > Acked-by: Mel Gorman <mgorman@techsingularity.net>
Thanks for the review!
| |