lkml.org 
[lkml]   [2017]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: lib/test_kmod.c:750: possible garbled statement order ?
On Mon, Jul 17, 2017 at 07:38:40AM +0000, David Binderman wrote:
> Hello there,
>
>
> lib/test_kmod.c:750]: (style) Statements following return, break, continue, goto or throw will never be executed.
>
> case TEST_KMOD_FS_TYPE:
> break;
> kfree_const(config->test_fs);
> config->test_driver = NULL;
> copied = config_copy_test_fs(config, test_str,
> strlen(test_str));
> default:
>
> Suggest move the break to just before the default label.
>
> Regards

Thanks David, Dan Carpenter sent a fix for this [0] and I've queued the
patch in.

[0] https://lkml.kernel.org/r/20170707084117.jbi3g364jz75liay@mwanda

Luis

\
 
 \ /
  Last update: 2017-08-02 01:23    [W:0.019 / U:22.256 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site